Add DevContainers support for editing project locally #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a Dockerfile and docker-compose.yaml in order to allow containerized local development.
|
@NyanKiyoshi is attempting to deploy a commit to the Saleor Commerce Team on Vercel. A member of the Team first needs to authorize it. |
NyanKiyoshi
commented
Mar 20, 2025
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "name": "saleor-docs", | |||
There was a problem hiding this comment.
Needed otherwise the package-lock.json file will change the application name from saleor-docs to app as NPM was trying to guess the name of the project
|
After some internal feedback, we will changing the pull request to add support for devcontainers instead |
NyanKiyoshi
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aniav
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for remote development using DevContainers, as well as plain-Dockerfile and docker-compose.yaml stack for containerized local development (with or without devcontainers, e.g., using
docker-compose upcommand manually).Warning
It may be unstable, NPM often complains about
package-lock.jsonfile being outdated inmainbranch, something or someone may be pushing brokenpackage-lock.jsonfiles which may prevent thedocker-composestack from running (usingnpm ci)